|
||||||
Views:
11,030,476 |
Main | FAQ | IRC chat | Memberlist | Active users | Latest posts | Stats | Ranks | Online users | Search | 11-21-24 11:54 AM |
||||
Guest: Register | Login |
0 users currently in AcmlmBoard Developer Zone | 5 bots |
Main - AcmlmBoard Developer Zone - ABII: Bugfixes and Code Fragments |
Emuz |
| ||
Site Administrator
11 Hit Combo: Mother's Rosario Level: 109 Posts: 448/3393 EXP: 13563466 Next: 396179 Since: 12-30-11 From: Akron, Ohio; USA Last post: 114 days Last view: 3 days |
Merged no self +1ing The Dynamic Profile Administrator™"Never Knows Best" Note: if you can see this my layout broke. ALL THE CREDITS WILL BE REVEALED!! 'Victory Noriko' by @thatsheepagain. 'Chibi Dance Noriko' by @Haru__Kitsu. 'Deity's Night Out (Featuring Gabbie)' by @thatsheepagain Noriko Emotes by @Haru__Kitsu. Side Bar Noriko by @thatsheepagain 'Noriko's Nature Walk' by @projectTiGER_ Emotive Noriko by @thatsheepagain. "Space Candy Noriko" by BerryVerrine. "Super Sharp Noriko" by Xionfes. A gift illustration from the wonderful EverKinzPony! "Magical Girl Noriko" by @cute_hospital! "Patient Chibi Noriko" by @Ruii_ki! 'Dapper '60s Noriko' by @thatsheepagain. 'Shiny Chibi Noriko' by @inioli. 'Flower Veil Noriko' by @Sushiee_. 'Noriko in Realism' by @_Sarybuu. 'Noriko's Midnight Adventure' by @projectTiGER_ 'Yukata Noriko' by @yunyunmaru_ 'Birthday Wishes Noriko' by @thatsheepagain |
Emuz |
| ||
Site Administrator
11 Hit Combo: Mother's Rosario Level: 109 Posts: 459/3393 EXP: 13563466 Next: 396179 Since: 12-30-11 From: Akron, Ohio; USA Last post: 114 days Last view: 3 days |
Also mention of the <base> tag was made. 15:15:24 Liliana | funnily enough 15:15:43 Liliana | <base> isn't filtered 15:15:46 Liliana | it isn't too bad here 15:15:53 Liliana | but on Jul you can steal the credentials that way. 15:16:03 Liliana | 15:16:34 Liliana | because the Submit reply button is affected too, and on the old 1.x acmlmboards it transfers your username and password. 5:16:35 Liliana | uh oh! 15:18:54 Liliana | so if you have it redirect to a php file which does a silent redirect but makes sure username/password are saved nobody will notice 15:20:22 Liliana | I gotta admit, the <base> tag is really underused so it isn't surprising that nobody noticed this horrible exploit Maybe we should build a filter for it? The Dynamic Profile Administrator™"Never Knows Best" Note: if you can see this my layout broke. ALL THE CREDITS WILL BE REVEALED!! 'Victory Noriko' by @thatsheepagain. 'Chibi Dance Noriko' by @Haru__Kitsu. 'Deity's Night Out (Featuring Gabbie)' by @thatsheepagain Noriko Emotes by @Haru__Kitsu. Side Bar Noriko by @thatsheepagain 'Noriko's Nature Walk' by @projectTiGER_ Emotive Noriko by @thatsheepagain. "Space Candy Noriko" by BerryVerrine. "Super Sharp Noriko" by Xionfes. A gift illustration from the wonderful EverKinzPony! "Magical Girl Noriko" by @cute_hospital! "Patient Chibi Noriko" by @Ruii_ki! 'Dapper '60s Noriko' by @thatsheepagain. 'Shiny Chibi Noriko' by @inioli. 'Flower Veil Noriko' by @Sushiee_. 'Noriko in Realism' by @_Sarybuu. 'Noriko's Midnight Adventure' by @projectTiGER_ 'Yukata Noriko' by @yunyunmaru_ 'Birthday Wishes Noriko' by @thatsheepagain |
Kawa |
| ||
Retired Staff
Not okay Prophet of Celestia Level: 94 Posts: 374/2423 EXP: 8183319 Next: 173338 Since: 01-01-12 From: The Netherlands Last post: 2237 days Last view: 552 days |
lib/post.php, line 73: $tags=array('script','iframe','textarea','noscript','meta','xmp','plaintext','base');
Problem solved. |
Emuz |
| ||
Site Administrator
11 Hit Combo: Mother's Rosario Level: 109 Posts: 461/3393 EXP: 13563466 Next: 396179 Since: 12-30-11 From: Akron, Ohio; USA Last post: 114 days Last view: 3 days |
Gywall's replacement for the sprite's Random Number Generator..
I worked with it a little bit but right now it doesn't work. I think it has something to do with the SQL. I wanted to document it here The Dynamic Profile Administrator™"Never Knows Best" Note: if you can see this my layout broke. ALL THE CREDITS WILL BE REVEALED!! 'Victory Noriko' by @thatsheepagain. 'Chibi Dance Noriko' by @Haru__Kitsu. 'Deity's Night Out (Featuring Gabbie)' by @thatsheepagain Noriko Emotes by @Haru__Kitsu. Side Bar Noriko by @thatsheepagain 'Noriko's Nature Walk' by @projectTiGER_ Emotive Noriko by @thatsheepagain. "Space Candy Noriko" by BerryVerrine. "Super Sharp Noriko" by Xionfes. A gift illustration from the wonderful EverKinzPony! "Magical Girl Noriko" by @cute_hospital! "Patient Chibi Noriko" by @Ruii_ki! 'Dapper '60s Noriko' by @thatsheepagain. 'Shiny Chibi Noriko' by @inioli. 'Flower Veil Noriko' by @Sushiee_. 'Noriko in Realism' by @_Sarybuu. 'Noriko's Midnight Adventure' by @projectTiGER_ 'Yukata Noriko' by @yunyunmaru_ 'Birthday Wishes Noriko' by @thatsheepagain |
Kawa |
| ||
Retired Staff
Not okay Prophet of Celestia Level: 94 Posts: 378/2423 EXP: 8183319 Next: 173338 Since: 01-01-12 From: The Netherlands Last post: 2237 days Last view: 552 days |
"Mew Tier" is a misnomer. Mew does not appear in the game at all, no way, no how, and can only be recieved through external means. |
Emuz |
| ||
Site Administrator
11 Hit Combo: Mother's Rosario Level: 109 Posts: 469/3393 EXP: 13563466 Next: 396179 Since: 12-30-11 From: Akron, Ohio; USA Last post: 114 days Last view: 3 days |
Indeed. However, his system he can call it what he wants. I think he was refering to the actual Mew sprite on in this system. The Dynamic Profile Administrator™"Never Knows Best" Note: if you can see this my layout broke. ALL THE CREDITS WILL BE REVEALED!! 'Victory Noriko' by @thatsheepagain. 'Chibi Dance Noriko' by @Haru__Kitsu. 'Deity's Night Out (Featuring Gabbie)' by @thatsheepagain Noriko Emotes by @Haru__Kitsu. Side Bar Noriko by @thatsheepagain 'Noriko's Nature Walk' by @projectTiGER_ Emotive Noriko by @thatsheepagain. "Space Candy Noriko" by BerryVerrine. "Super Sharp Noriko" by Xionfes. A gift illustration from the wonderful EverKinzPony! "Magical Girl Noriko" by @cute_hospital! "Patient Chibi Noriko" by @Ruii_ki! 'Dapper '60s Noriko' by @thatsheepagain. 'Shiny Chibi Noriko' by @inioli. 'Flower Veil Noriko' by @Sushiee_. 'Noriko in Realism' by @_Sarybuu. 'Noriko's Midnight Adventure' by @projectTiGER_ 'Yukata Noriko' by @yunyunmaru_ 'Birthday Wishes Noriko' by @thatsheepagain |
Kawa |
| ||
Retired Staff
Not okay Prophet of Celestia Level: 94 Posts: 492/2423 EXP: 8183319 Next: 173338 Since: 01-01-12 From: The Netherlands Last post: 2237 days Last view: 552 days |
Item shop has an unclosed anchor tag. These days, we do #foo links by id, not by <a name=...>.
shop.php, line 248:
|
Emuz |
| ||
Site Administrator
11 Hit Combo: Mother's Rosario Level: 109 Posts: 534/3393 EXP: 13563466 Next: 396179 Since: 12-30-11 From: Akron, Ohio; USA Last post: 114 days Last view: 3 days |
I tried to find in the code why there is a space between the Group name (IE: Administrator) and the name. I think we should close the gap. (and get rid of the _.png spacer? heh) The Dynamic Profile Administrator™"Never Knows Best" Note: if you can see this my layout broke. ALL THE CREDITS WILL BE REVEALED!! 'Victory Noriko' by @thatsheepagain. 'Chibi Dance Noriko' by @Haru__Kitsu. 'Deity's Night Out (Featuring Gabbie)' by @thatsheepagain Noriko Emotes by @Haru__Kitsu. Side Bar Noriko by @thatsheepagain 'Noriko's Nature Walk' by @projectTiGER_ Emotive Noriko by @thatsheepagain. "Space Candy Noriko" by BerryVerrine. "Super Sharp Noriko" by Xionfes. A gift illustration from the wonderful EverKinzPony! "Magical Girl Noriko" by @cute_hospital! "Patient Chibi Noriko" by @Ruii_ki! 'Dapper '60s Noriko' by @thatsheepagain. 'Shiny Chibi Noriko' by @inioli. 'Flower Veil Noriko' by @Sushiee_. 'Noriko in Realism' by @_Sarybuu. 'Noriko's Midnight Adventure' by @projectTiGER_ 'Yukata Noriko' by @yunyunmaru_ 'Birthday Wishes Noriko' by @thatsheepagain |
Epele |
| ||
Site Administrator
The Sorceress. Boing~ Level: 237 Posts: 674/20774 EXP: 205437200 Next: 2541734 Since: 01-01-12 From: UK Last post: 1051 days Last view: 11 hours |
Posted by Emuz I found it. Neutered both.. About to push to git. The world could always use more heroes! |
Epele |
| ||
Site Administrator
The Sorceress. Boing~ Level: 237 Posts: 689/20774 EXP: 205437200 Next: 2541734 Since: 01-01-12 From: UK Last post: 1051 days Last view: 11 hours |
Fixed the empty thread title. Also made a minimum title length of 4 characters excluding whitespace (which should stop some very sloppy spam too).
< and similar turning into html when editing a post.. Since changing them every time you edit a post isn't fun. And stopped the quick reply appearing in a closed thread.. which was.. a bit weird. The world could always use more heroes! |
KP |
| ||
Retired Staff
NES Game Aficionado Level: 73 Posts: 159/1354 EXP: 3418326 Next: 67542 Since: 01-02-12 Last post: 2180 days Last view: 1688 days |
Might I suggest something about the spiffy new instant redirects? I believe the web2.0ish window that pops up telling you the post was a success is quite invasive. Could we plug that in between the end of the list of posts and before the warp whistle reply? And have it use the header bar image from the appropriate themes? |
Kawa |
| ||
Retired Staff
Not okay Prophet of Celestia Level: 94 Posts: 718/2423 EXP: 8183319 Next: 173338 Since: 01-01-12 From: The Netherlands Last post: 2237 days Last view: 552 days |
Agreed. That might be much nicer. |
Emuz |
| ||
Site Administrator
11 Hit Combo: Mother's Rosario Level: 109 Posts: 546/3393 EXP: 13563466 Next: 396179 Since: 12-30-11 From: Akron, Ohio; USA Last post: 114 days Last view: 3 days |
That's actually how Bouche was going to do it. I'd have to say I would agree. I would like it inline with the rest of the forum better than a free-floating object now that I've used it for a while. (could have it optionally still free float per user's discretion) The Dynamic Profile Administrator™"Never Knows Best" Note: if you can see this my layout broke. ALL THE CREDITS WILL BE REVEALED!! 'Victory Noriko' by @thatsheepagain. 'Chibi Dance Noriko' by @Haru__Kitsu. 'Deity's Night Out (Featuring Gabbie)' by @thatsheepagain Noriko Emotes by @Haru__Kitsu. Side Bar Noriko by @thatsheepagain 'Noriko's Nature Walk' by @projectTiGER_ Emotive Noriko by @thatsheepagain. "Space Candy Noriko" by BerryVerrine. "Super Sharp Noriko" by Xionfes. A gift illustration from the wonderful EverKinzPony! "Magical Girl Noriko" by @cute_hospital! "Patient Chibi Noriko" by @Ruii_ki! 'Dapper '60s Noriko' by @thatsheepagain. 'Shiny Chibi Noriko' by @inioli. 'Flower Veil Noriko' by @Sushiee_. 'Noriko in Realism' by @_Sarybuu. 'Noriko's Midnight Adventure' by @projectTiGER_ 'Yukata Noriko' by @yunyunmaru_ 'Birthday Wishes Noriko' by @thatsheepagain |
Epele |
| ||
Site Administrator
The Sorceress. Boing~ Level: 237 Posts: 746/20774 EXP: 205437200 Next: 2541734 Since: 01-01-12 From: UK Last post: 1051 days Last view: 11 hours |
Posted by KP9000 I went based on information I was given originally which pointed me to placing it at the top. Might try testing out moving it to new locations tomorrow.. and support for edit post too. The world could always use more heroes! |
Emuz |
| ||
Site Administrator
11 Hit Combo: Mother's Rosario Level: 109 Posts: 547/3393 EXP: 13563466 Next: 396179 Since: 12-30-11 From: Akron, Ohio; USA Last post: 114 days Last view: 3 days |
Yeah, I may not have been 100% clear, I think I wasn't all there when you asked me about it. For clarity I'll retype it, just in case
Bouche's original idea was a table block, (similar to the ones that have the query and "powered by Acmlm" image at the footer of the page.) and have it show between the header/menu block and the start of the page data (on a thread it would be before the thread title and new reply line. for example) If there was an error it would return you to the previous page with the block saying why it was error state'd. That's what Bouche and I discussed anyway The Dynamic Profile Administrator™"Never Knows Best" Note: if you can see this my layout broke. ALL THE CREDITS WILL BE REVEALED!! 'Victory Noriko' by @thatsheepagain. 'Chibi Dance Noriko' by @Haru__Kitsu. 'Deity's Night Out (Featuring Gabbie)' by @thatsheepagain Noriko Emotes by @Haru__Kitsu. Side Bar Noriko by @thatsheepagain 'Noriko's Nature Walk' by @projectTiGER_ Emotive Noriko by @thatsheepagain. "Space Candy Noriko" by BerryVerrine. "Super Sharp Noriko" by Xionfes. A gift illustration from the wonderful EverKinzPony! "Magical Girl Noriko" by @cute_hospital! "Patient Chibi Noriko" by @Ruii_ki! 'Dapper '60s Noriko' by @thatsheepagain. 'Shiny Chibi Noriko' by @inioli. 'Flower Veil Noriko' by @Sushiee_. 'Noriko in Realism' by @_Sarybuu. 'Noriko's Midnight Adventure' by @projectTiGER_ 'Yukata Noriko' by @yunyunmaru_ 'Birthday Wishes Noriko' by @thatsheepagain |
Emuz |
| ||
Site Administrator
11 Hit Combo: Mother's Rosario Level: 109 Posts: 624/3393 EXP: 13563466 Next: 396179 Since: 12-30-11 From: Akron, Ohio; USA Last post: 114 days Last view: 3 days |
Good point, I never noticed that. Adding it to the important list. The Dynamic Profile Administrator™"Never Knows Best" Note: if you can see this my layout broke. ALL THE CREDITS WILL BE REVEALED!! 'Victory Noriko' by @thatsheepagain. 'Chibi Dance Noriko' by @Haru__Kitsu. 'Deity's Night Out (Featuring Gabbie)' by @thatsheepagain Noriko Emotes by @Haru__Kitsu. Side Bar Noriko by @thatsheepagain 'Noriko's Nature Walk' by @projectTiGER_ Emotive Noriko by @thatsheepagain. "Space Candy Noriko" by BerryVerrine. "Super Sharp Noriko" by Xionfes. A gift illustration from the wonderful EverKinzPony! "Magical Girl Noriko" by @cute_hospital! "Patient Chibi Noriko" by @Ruii_ki! 'Dapper '60s Noriko' by @thatsheepagain. 'Shiny Chibi Noriko' by @inioli. 'Flower Veil Noriko' by @Sushiee_. 'Noriko in Realism' by @_Sarybuu. 'Noriko's Midnight Adventure' by @projectTiGER_ 'Yukata Noriko' by @yunyunmaru_ 'Birthday Wishes Noriko' by @thatsheepagain |
Arisotura |
| ||
Developer
pancakes Level: 84 Posts: 243/1870 EXP: 5546095 Next: 115857 Since: 01-05-12 From: France Last post: 37 days Last view: 37 days |
Looks like we got duplicate users:
Gohan - Finops Apparently the two requests have been processed at the same time, and the 'username already taken' check missed it. Adding a UNIQUE index to users.name would prevent that (and potentially speed up certain parts of the board). Similarly, the register process could be optimized a little bit: * I'm for removing chkproxy(). Does it provide any benefit that outbalances the time it takes to complete? (not to mention that it could be a vector for DoS attacks) * the 'username already taken' check could be optimized too. The str_replace() part can be ported to SQL. Also is there a reason that all str_replace()s there are done twice? ____________________ Kuribo64 - melonDS want some revolution in your coffee? |
Emuz |
| ||
Site Administrator
11 Hit Combo: Mother's Rosario Level: 109 Posts: 739/3393 EXP: 13563466 Next: 396179 Since: 12-30-11 From: Akron, Ohio; USA Last post: 114 days Last view: 3 days |
Posted by Mega-Mario Please remove the chkproxy() POS, and go ahead with the optimization to the sql/improvement of the username duplicate check. Please provide me a sql query in the sql thread so I may apply it quickly to the live board. As for the double str_replace() may be the display name system. It needs the same checks. Frankly if we function the filter out we could make it easier to alter or add to later. The Dynamic Profile Administrator™"Never Knows Best" Note: if you can see this my layout broke. ALL THE CREDITS WILL BE REVEALED!! 'Victory Noriko' by @thatsheepagain. 'Chibi Dance Noriko' by @Haru__Kitsu. 'Deity's Night Out (Featuring Gabbie)' by @thatsheepagain Noriko Emotes by @Haru__Kitsu. Side Bar Noriko by @thatsheepagain 'Noriko's Nature Walk' by @projectTiGER_ Emotive Noriko by @thatsheepagain. "Space Candy Noriko" by BerryVerrine. "Super Sharp Noriko" by Xionfes. A gift illustration from the wonderful EverKinzPony! "Magical Girl Noriko" by @cute_hospital! "Patient Chibi Noriko" by @Ruii_ki! 'Dapper '60s Noriko' by @thatsheepagain. 'Shiny Chibi Noriko' by @inioli. 'Flower Veil Noriko' by @Sushiee_. 'Noriko in Realism' by @_Sarybuu. 'Noriko's Midnight Adventure' by @projectTiGER_ 'Yukata Noriko' by @yunyunmaru_ 'Birthday Wishes Noriko' by @thatsheepagain |
Arisotura |
| ||
Developer
pancakes Level: 84 Posts: 244/1870 EXP: 5546095 Next: 115857 Since: 01-05-12 From: France Last post: 37 days Last view: 37 days |
Nah, about the double str_replace() thing, I meant:
Any reason it's done twice? Also, if we go for cleaning register.php up, I'm also for removing all those old hacks (SamuraiHax, pass=='asdf', pass='itsatest'...). Edit- oh right, I get it. The second pass replaces character 0xA0 (unbreakable space). Hmm... I wonder if \s in a regexp would match that space... ____________________ Kuribo64 - melonDS want some revolution in your coffee? |
Emuz |
| ||
Site Administrator
11 Hit Combo: Mother's Rosario Level: 109 Posts: 740/3393 EXP: 13563467 Next: 396178 Since: 12-30-11 From: Akron, Ohio; USA Last post: 114 days Last view: 3 days |
Yeah it's that second white space char.
The 'hax' all can be removed. I am surprised I didn't do it last time I did a clean out. All of those apply to board2 specifically anyway. The Dynamic Profile Administrator™"Never Knows Best" Note: if you can see this my layout broke. ALL THE CREDITS WILL BE REVEALED!! 'Victory Noriko' by @thatsheepagain. 'Chibi Dance Noriko' by @Haru__Kitsu. 'Deity's Night Out (Featuring Gabbie)' by @thatsheepagain Noriko Emotes by @Haru__Kitsu. Side Bar Noriko by @thatsheepagain 'Noriko's Nature Walk' by @projectTiGER_ Emotive Noriko by @thatsheepagain. "Space Candy Noriko" by BerryVerrine. "Super Sharp Noriko" by Xionfes. A gift illustration from the wonderful EverKinzPony! "Magical Girl Noriko" by @cute_hospital! "Patient Chibi Noriko" by @Ruii_ki! 'Dapper '60s Noriko' by @thatsheepagain. 'Shiny Chibi Noriko' by @inioli. 'Flower Veil Noriko' by @Sushiee_. 'Noriko in Realism' by @_Sarybuu. 'Noriko's Midnight Adventure' by @projectTiGER_ 'Yukata Noriko' by @yunyunmaru_ 'Birthday Wishes Noriko' by @thatsheepagain |
Main - AcmlmBoard Developer Zone - ABII: Bugfixes and Code Fragments |
Acmlmboard v2.5.6 (06/11/2024) © 2005-2024 Acmlm, Emuz, et al. |
MySQL - queries: 229, rows: 750/785, time: 8.534 seconds. |