Merged no self +1ing

The Grand Dip GreyMaria has an issue with the mail icon having a border in legacy FF3. Do we wish to fix it (border=0 may fix it)?

Also mention of the <base> tag was made.

15:15:24 Liliana | funnily enough
15:15:43 Liliana | <base> isn't filtered
15:15:46 Liliana | it isn't too bad here
15:15:53 Liliana | but on Jul you can steal the credentials that way.
15:16:03 Liliana |
15:16:34 Liliana | because the Submit reply button is affected too, and on the old 1.x acmlmboards it transfers your username and password.
5:16:35 Liliana | uh oh!
15:18:54 Liliana | so if you have it redirect to a php file which does a silent redirect but makes sure username/password are saved nobody will notice
15:20:22 Liliana | I gotta admit, the <base> tag is really underused so it isn't surprising that nobody noticed this horrible exploit



Maybe we should build a filter for it?

Gywall's replacement for the sprite's Random Number Generator..

// Redone the roll [Gywall] // If I broke anything, blame the rabbits. :) $monRarity = rand(0,6464646)%100; $monRequest = @mysql_result("SELECT count(*) FROM sprites WHERE rarity <= ".$monRarity); $monNumpty = rand(0,6464646)%$monRequest; $monData = array(); $monData = mysql_query("SELECT * FROM sprites WHERE rarity <= ".$monRarity." LIMIT ".$monNumpty.",1");;

---

08:54:06 < Gywall> That should be pretty much it
08:54:33 < Gywall> Replaces lines 37 to 41 on that pastebin
09:01:04 < Gywall> In theory, that code *should* be compatible.
09:32:20 < Gywall> Default of 0
09:32:28 < Gywall> 0 = Common
09:32:39 < Gywall> 50 would be Uncommon/Rare
09:32:45 < Gywall> 99 = Ultra rare
09:32:55 < Gywall> Hell, 80 would be enough to call Rare
09:40:23 < Gywall> I'd say 0 = Common | 20 = Uncommon | 40 = Slightly Rare | 60 = Rare | 80 = Very Rare | 99 = Mew Tier

---

I worked with it a little bit but right now it doesn't work. I think it has something to do with the SQL. I wanted to document it here

Indeed. However, his system he can call it what he wants. I think he was refering to the actual Mew sprite on in this system.

I tried to find in the code why there is a space between the Group name (IE: Administrator) and the name. I think we should close the gap. (and get rid of the _.png spacer? heh)

That's actually how Bouche was going to do it. I'd have to say I would agree. I would like it inline with the rest of the forum better than a free-floating object now that I've used it for a while. (could have it optionally still free float per user's discretion)

Yeah, I may not have been 100% clear, I think I wasn't all there when you asked me about it. For clarity I'll retype it, just in case

Bouche's original idea was a table block, (similar to the ones that have the query and "powered by Acmlm" image at the footer of the page.) and have it show between the header/menu block and the start of the page data (on a thread it would be before the thread title and new reply line. for example)

If there was an error it would return you to the previous page with the block saying why it was error state'd.

That's what Bouche and I discussed anyway

Mega-Mario | also editpost shouldn't allow dummy edits like that Mega-Mario | I could make a script that continually sends POST requests to editpost and flood the database :P

Good point, I never noticed that. Adding it to the important list.

Posted by Mega-Mario

---

Looks like we got duplicate users:
Gohan - Finops

Apparently the two requests have been processed at the same time, and the 'username already taken' check missed it.

Adding a UNIQUE index to users.name would prevent that (and potentially speed up certain parts of the board).

Similarly, the register process could be optimized a little bit:
* I'm for removing chkproxy(). Does it provide any benefit that outbalances the time it takes to complete? (not to mention that it could be a vector for DoS attacks)
* the 'username already taken' check could be optimized too. The str_replace() part can be ported to SQL. Also is there a reason that all str_replace()s there are done twice?

---

Please remove the chkproxy() POS, and go ahead with the optimization to the sql/improvement of the username duplicate check.

Please provide me a sql query in the sql thread so I may apply it quickly to the live board.

As for the double str_replace() may be the display name system. It needs the same checks. Frankly if we function the filter out we could make it easier to alter or add to later.

Yeah it's that second white space char.

The 'hax' all can be removed. I am surprised I didn't do it last time I did a clean out. All of those apply to board2 specifically anyway.