I agree with this generally, but still wanna say a few things.

As Gywall pointed out, having brackets for one-line if statements makes the code feel more bloated, I'm not a fan of it.

Also, syntax like $user[email] is deprecated I think, it throws E_NOTICE level warnings. The proper thing is $user['email'] (or {$user['email']} if the variable is used inside a double-quoted string). $user["email"] works too but looks kinda meh.

As for SQL well... ` is annoying to type on certain keyboard layouts, namely mine (French azerty): AltGr-7, space.

This brings me to mention prepared queries. The code uses a simple syntax which is nice. However there's an oddity, it seems to be replacing the arguments starting from the end.

I figure it's worth mentioning that I came up with a different syntax for ABXD, one that allows for more flexibility than raw SQL. It supports compacted fieldlists, manipulating table names (for example, prefixing them), and of course escaping user input and all. For example, the following code:

Query("SELECT u.(id, name, sex, powerlevel), t.(id, title) FROM {users} u LEFT JOIN {threads} t ON t.user=u.id WHERE (u.id={0} AND t.title={1}) OR u.name={1}", 1337, "Robert'; DROP TABLE students; -- ");

results in the following query:

SELECT u.id AS u_id, u.name AS u_name, u.sex AS u_sex, u.powerlevel AS u_powerlevel, t.id AS t_id, t.title AS t_title FROM prefix_users u LEFT JOIN prefix_threads t ON t.user=u.id WHERE (u.id=1337 AND t.title='Robert\'; DROP TABLE students; -- ') OR u.name='Robert\'; DROP TABLE students; -- '

This method would for example allow to set the minimal user field list as a variable, so that if you want to change the userlink() function to display more stuff, you don't need to modify all the queries...

____________________
Kuribo64 - melonDS

want some revolution in your coffee?

The `` problem with SQL is that you can't always omit it. Some field names conflict with SQL keywords (namely 'order' fields), so if you don't put them in graves, MySQL will throw an error in your face...

____________________
Kuribo64 - melonDS

want some revolution in your coffee?

If we start using the new layout functions, we must make them flexible as I said. Right now, none of them would allow us to reproduce the old pages (namely newreply/newthread/etc) without hardcoding some HTML.

____________________
Kuribo64 - melonDS

want some revolution in your coffee?

I'd agree to merge some of the files, as long as the final size remains reasonable. I wouldn't want everything to become a huge hub that does 15314 functions...

____________________
Kuribo64 - melonDS

want some revolution in your coffee?